Conversation
rjan90
approved these changes
Dec 13, 2024
masih
approved these changes
Dec 13, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion in #12781 made me check how many instances of bad capitalisation we have left in the repo, and it's not very many so I decided to fix these. I'm just limiting myself to those fixes, not the misuse of
fmt.Errorfor the xerrors/errors inconsistencies.golangci-lint is supposed to catch these for us, but I think it's deprecated its checking of xerrors messages, simply reporting those as deprecated instead and we explicitly ignore that deprecation error, so we're left without checking.
I think it might be worthwhile also putting actual staticcheck in the mix, not just the golangci-lint staticcheck module which is different, but there's a lot more errors to fix that it throws up before we do that. Something to chip away at.